Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary architecture of application to payload #389

Merged
merged 3 commits into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@fractalwrench
Copy link
Contributor

fractalwrench commented Dec 4, 2018

Goal

64-bit devices on Android can load 32-bit libraries, as mixing between 32/64 bits is not allowed. This changeset explicitly adds the binary arch used by the app at runtime to handled and unhandled reports, to allow the pipeline to select the correct mapping file for stacktrace deobfuscation.

Changeset

  • Added bsg_binary_arch to calculate the current architecture.
  • Added field to handled native reports by setting the binary arch on bugsnag_init, via the NativeInterface.
  • Added field to unhandled native reports by setting the binary arch in the serializer.

Tests

Altered existing mazerunner scenarios to ensure that a handled/unhandled native exception contain the app.binaryArch field.

fractalwrench added some commits Dec 4, 2018

feat: add binary arch of application to payload
64-bit devices on Android can load 32-bit libraries, as mixing between 32/64 bits is not allowed.
This changeset explicitly adds the binary arch used by the app at runtime to handled and unhandled
reports, to allow the pipeline to select the correct mapping file for stacktrace deobfuscation.

@kattrali kattrali merged commit 7c062f9 into next Dec 10, 2018

1 check failed

coverage/coveralls Coverage decreased (-51.0%) to 0.0%
Details

@kattrali kattrali deleted the send-binary-arch branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.