Allow calling Bugsnag.notify() with no arguments #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should actually notify in this case |
|
Should we just send |
|
as the message maybe. Can we put something like BugsnagError as the class? |
foxyblocks
changed the title
eanakashima
reviewed
Oct 6, 2016
| @@ -115,6 +118,12 @@ | |||
| // Notify Bugsnag about an error by passing in a `name` and `message`, | |||
| // without requiring an exception. | |||
| self.notify = function (name, message, metaData, severity) { | |||
| if (!name) { | |||
| name = "UnspecifiedBugsnagError"; | |||
There was a problem hiding this comment.
Might be worth pulling this to the top of the file where we declare some other constant-esque variables?
|
👍 Looks good! One thought: since this is a manual call to Bugsnag.notify, maybe the error class doesn't need to have "Error" in it? A class name like |
foxyblocks
force-pushed
the
check-notify-arguments
branch
from
41e37dd
to
cf7d6de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #196