Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Symfony 5 #92

Closed
wants to merge 1 commit into from
Closed

Add support for Symfony 5 #92

wants to merge 1 commit into from

Conversation

@pyrech
Copy link

pyrech commented Nov 16, 2019

Ref #91

Two things were needed:

  • bypass the removal of the root_dir parameter and use the project_dir if available (a new parameter bugsnag.symfony_root was added);
  • add support for the new event classes.

I kept support for Symfony < 5 and Symfony >= 5.0 at the same time. I also added CI build for PHP 7.2 and PHP 7.3.

I also added an example application for Symfony 5.0.

@pyrech pyrech force-pushed the pyrech:symfony-5 branch from ad93fe0 to 9e5224e Nov 16, 2019
@pyrech pyrech force-pushed the pyrech:symfony-5 branch from 9e5224e to 0dc4147 Nov 16, 2019
@@ -145,14 +157,11 @@ public static function getSubscribedEvents()
KernelEvents::EXCEPTION => ['onKernelException', 128],
];
// Added ConsoleEvents in Symfony 2.3

This comment has been minimized.

Copy link
@pyrech

pyrech Nov 16, 2019

Author

I removed this check as Symfony < 2.7 is no longer supported

@pyrech pyrech mentioned this pull request Nov 16, 2019
@pyrech

This comment has been minimized.

Copy link
Author

pyrech commented Nov 28, 2019

Hello @kattrali, can I have some feedback on this PR? We need Symfony 5 updates in several projects but are blocked because this bundle is not yet compatible.

It looks like the tests are failing on PHP 5 because of a memory limit...

@mattdyoung

This comment has been minimized.

Copy link

mattdyoung commented Nov 28, 2019

Hi @pyrech

We are actively working on testing this right now so we hope to be able to release in the near future.

Thanks!

@pyrech

This comment has been minimized.

Copy link
Author

pyrech commented Nov 28, 2019

Thanks 🙏 😍

@Cawllec Cawllec mentioned this pull request Nov 28, 2019
@Cawllec

This comment has been minimized.

Copy link
Contributor

Cawllec commented Nov 28, 2019

Hi @pyrech, we've pulled it onto a branch and created a PR at #93, which we'll test, review, and merge as soon as we can.

Thanks for the contribution!

@Cawllec Cawllec closed this Nov 28, 2019
@pyrech pyrech deleted the pyrech:symfony-5 branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.