fix formatting of stacktraces containing wrapper entries #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
approved these changes
May 23, 2023
tomlongridge
approved these changes
May 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Some Unity stacktraces contain lines like the following
at (wrapper managed-to-native) Program.NativeMethod(Program/StructToMarshal)Our trace formatter was confused by this and stripping out useful information, ending up with something like this:
at(wrapper managed-to-native):0Now it will match the wrapper info and produce a frame like so:
(wrapper managed-to-native)Program.NativeMethod(Program/StructToMarshal)Changeset
Add a regex check for any wrapper type before a method name. If matched, then it temporarly removes it, allows the normal method parser to do it's work, and then reattaches the wrapper name to the beginning of the line.
Testing
Added a unit test