New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional remove sourcemap #2

Closed
sugarshin opened this Issue Feb 23, 2018 · 9 comments

Comments

Projects
None yet
7 participants
@sugarshin
Copy link

sugarshin commented Feb 23, 2018

Hi,

I need removeSourcemap option, like https://github.com/bakunyo/bugsnag-sourcemap-webpack-plugin#options

Thank you.

@bengourley

This comment has been minimized.

Copy link
Member

bengourley commented Mar 15, 2018

Thanks for the request @sugarshin, I've added this to our internal backlog.

@sugarshin

This comment has been minimized.

Copy link
Author

sugarshin commented Mar 30, 2018

Look forward to that.

@bohdanbirdie

This comment has been minimized.

Copy link

bohdanbirdie commented Nov 2, 2018

+1 here, would be great to have this option!

@thrstn

This comment has been minimized.

Copy link

thrstn commented Dec 14, 2018

+1 I really need this option.

@SayakMukhopadhyay

This comment has been minimized.

Copy link

SayakMukhopadhyay commented Dec 16, 2018

This feature might be a small one but a very important one nonetheless. Sourcemaps needs to be generated for Bugsnag to work but they should never be served. Although one can workaround this, having an option to delete the maps would be great.

@bengourley

This comment has been minimized.

Copy link
Member

bengourley commented Dec 18, 2018

See #25 (comment). We're not going to add this functionality but I'm happy to help figure out an alternative solution, such as contributing an exclude config option to whatever deploy tool you use.

@bengourley bengourley closed this Dec 18, 2018

@asgeo1

This comment has been minimized.

Copy link

asgeo1 commented Dec 20, 2018

I'm using Netlify, so it pulls from my git repo directly, and builds and deploys automatically. I don't think they have an option to filter out *.js.map files from dist, or to restrict access to them. I think deleting them after the upload to bugsnag is my best option.

So I can code that myself, but surely there's lots of use-cases like that.

I know what you're saying about it not being this plugins responsibility - but the only reason I turned on source-maps was to upload them to bugsnag, and something has to clean up these files afterwards... It would be a pretty convenient option to include. Hope you reconsider in the future!

@snmaynard

This comment has been minimized.

Copy link
Member

snmaynard commented Dec 20, 2018

With netlify you have a build command so you can do something like npm run build && rm dist/*.map?

@asgeo1

This comment has been minimized.

Copy link

asgeo1 commented Dec 20, 2018

Yes, I just tried that and it works 👍 In lieu of a more explicit option, something as simple as that will do the job. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment