Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate client tests to Jest #275

Closed
GentlemanHal opened this issue Mar 25, 2019 · 0 comments
Closed

Migrate client tests to Jest #275

GentlemanHal opened this issue Mar 25, 2019 · 0 comments
Assignees
Labels
for developers Changes that make development easier
Projects
Milestone

Comments

@GentlemanHal
Copy link
Member

We migrated the tests to Jest once before but then we migrated them to Mocha instead.

The reason we migrated away was because of Jests auto-mocking which made the tests quite slow and caused some issues.

In the almost 3 years since then, Jest has got faster and auto mocking is disabled by default. Also almost all developers I've talked to who've worked on React projects in the last few years have used Jest, and they find proxyquire mocking quite confusing.

Given this I think we should try using Jest again.

@GentlemanHal GentlemanHal added the for developers Changes that make development easier label Mar 25, 2019
@GentlemanHal GentlemanHal added this to the v4.0.0 milestone Mar 25, 2019
@GentlemanHal GentlemanHal self-assigned this Mar 25, 2019
@GentlemanHal GentlemanHal added this to To do in v4.0.0 via automation Mar 25, 2019
@GentlemanHal GentlemanHal moved this from To do to In progress in v4.0.0 Mar 25, 2019
GentlemanHal added a commit that referenced this issue Mar 25, 2019
v4.0.0 automation moved this from In progress to Done Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for developers Changes that make development easier
Projects
No open projects
v4.0.0
  
Done
Development

No branches or pull requests

1 participant