fix: align DiagnosticRelatedInformation with the LSP spec #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was a single DiagnosticRelatedInformation that was possible to be attached to a diagnostic. This change aligns it with the [LSP spec](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#diagnostic) making this a `List[DiagnosticRelatedInformation]` instead.
lukaszwawrzyk
approved these changes
Apr 9, 2022
16 tasks
|
@adpi2 do you see any compatibility implications? |
adpi2
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
@adpi2 do you see any compatibility implications?
I found no Scala open source tool that currently depends on relatedInformation. I checked Metals, Bloop, sbt and Mill.
Whether there are other tools out there that uses BSP, I don't know. If there are, chances are they don't use relatedInformation neither. So I am okay to break the compatibility here.
jastice
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was a single DiagnosticRelatedInformation that was
possible to be attached to a diagnostic. This change aligns it with the
LSP spec
making this a
List[DiagnosticRelatedInformation]instead.Partly addresses #319