Skip to content

fix(rust): ockam enroll command to not require custom attributes - #4202

Merged
mrinalwadhwa merged 1 commit into
build-trust:developfrom
p-gentili:gh_4135
Feb 11, 2023
Merged

fix(rust): ockam enroll command to not require custom attributes#4202
mrinalwadhwa merged 1 commit into
build-trust:developfrom
p-gentili:gh_4135

Conversation

@p-gentili

Copy link
Copy Markdown
Contributor

Current Behavior

ockam project enroll command requires any arguments to work even though, for the enrollment token workflow, none are needed.

Proposed Changes

Removed rust attribute to enforce passing CLI attributes when invoking ockam project enroll.
Fixes #4135

Checks

@p-gentili
p-gentili requested a review from a team as a code owner February 5, 2023 13:57
@mrinalwadhwa

Copy link
Copy Markdown
Member

@p-gentili Thank you for an awesome first pull request, while I review and before we can merge please

The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will make the commit as verified.

@p-gentili

Copy link
Copy Markdown
Contributor Author

@p-gentili Thank you for an awesome first pull request, while I review and before we can merge please

* [ ]  Accept the Ockam [Contributor License Agreement](https://github.com/build-trust/ockam-contributors/blob/main/CLA.md) by adding your Git/Github details in a row at the end of the [CONTRIBUTORS.csv](https://github.com/build-trust/ockam-contributors/blob/main/CONTRIBUTORS.csv) file in a separate pull request to the [build-trust/ockam-contributors](https://github.com/build-trust/ockam-contributors) repository.

The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will make the commit as verified.

Sorry about that, I must have missed this needed to be explicit. https://github.com/build-trust/ockam-contributors/pull/183

@p-gentili

Copy link
Copy Markdown
Contributor Author

@mrinalwadhwa I amended my commit with signature. Please re run the workflow.

@p-gentili

Copy link
Copy Markdown
Contributor Author

@mrinalwadhwa now I can see my signature when running git log --show-signature.

@p-gentili

Copy link
Copy Markdown
Contributor Author

@mrinalwadhwa it failed because the email associated with the key was not the one in the csv. Another try please (and thanks for your time...)

@mrinalwadhwa
mrinalwadhwa added this pull request to the merge queue Feb 11, 2023
Merged via the queue into build-trust:develop with commit 84101e2 Feb 11, 2023
@mrinalwadhwa

Copy link
Copy Markdown
Member

@p-gentili Thank you for fixing the errors and congratulations on an awesome first contribution 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ockam enroll command to not require custom attributes

2 participants