New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Key Validation in onboarding #40

Merged
merged 7 commits into from May 12, 2015

Conversation

Projects
None yet
2 participants
@czechboy0
Member

czechboy0 commented May 12, 2015

Fixes #30. Now SSH keys are validated that they have access to the specified repo. Uses a temp script that forces ssh keys and tries to call git ls-remote from the remote. Should help catch SSH key issues early.

Thanks, @accatyyc for help with this one!

czechboy0 added some commits May 11, 2015

work started on ssh key validation, now we just need a way to call th…
…e bash script and get its result to figure out the (in)validity of the provided ssh keys
at last! it works, i instead create a temp script which apparently ca…
…n be run just fine and NSTask doesn't lose his mind over it. not beautiful, but works. yayz.
@buildasaur

This comment has been minimized.

Collaborator

buildasaur commented May 12, 2015

Result of integration 1
Build failed 2 tests out of 11

@buildasaur

This comment has been minimized.

Collaborator

buildasaur commented May 12, 2015

Result of integration 2
Perfect build! All 9 tests passed. 👍

czechboy0 added a commit that referenced this pull request May 12, 2015

@czechboy0 czechboy0 merged commit 44da606 into master May 12, 2015

1 check passed

Buildasaur Buildasaur: Build passed!

@czechboy0 czechboy0 deleted the hd/ssh_key_validation branch May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment