From 0a2ffe57ce928a6ed49a97fe1b649658d8d112cb Mon Sep 17 00:00:00 2001 From: "Dustin J. Mitchell" Date: Thu, 17 Apr 2014 18:36:47 -0400 Subject: [PATCH] replace vacuuous mock.assert_called with mock.assert_called_with() --- master/buildbot/test/unit/test_schedulers_basic.py | 2 +- master/buildbot/test/unit/test_www_auth.py | 4 ++-- master/buildbot/test/unit/test_www_config.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/master/buildbot/test/unit/test_schedulers_basic.py b/master/buildbot/test/unit/test_schedulers_basic.py index cd92667072a..4526427b87a 100644 --- a/master/buildbot/test/unit/test_schedulers_basic.py +++ b/master/buildbot/test/unit/test_schedulers_basic.py @@ -162,7 +162,7 @@ def test_activate_calls_preStartConsumingChanges(self): @d.addCallback def check(_): - sched.preStartConsumingChanges.assert_called() + sched.preStartConsumingChanges.assert_called_with() return d def test_gotChange_no_treeStableTimer_unimportant(self): diff --git a/master/buildbot/test/unit/test_www_auth.py b/master/buildbot/test/unit/test_www_auth.py index 7b67ead25c8..c5caabbb015 100644 --- a/master/buildbot/test/unit/test_www_auth.py +++ b/master/buildbot/test/unit/test_www_auth.py @@ -196,7 +196,7 @@ def updateUserInfo(request): res = yield self.render_resource(self.rsrc, '/auth/login') self.assertEqual(res, "") self.failIf(self.auth.maybeAutoLogin.called) - self.auth.updateUserInfo.assert_called() + self.auth.updateUserInfo.assert_called_with(mock.ANY) self.assertEqual(self.master.session.user_info, {'email': 'him@org', 'username': 'him'}) @@ -212,4 +212,4 @@ def test_render(self): self.master.session.expire = mock.Mock() res = yield self.render_resource(self.rsrc, '/auth/logout') self.assertEqual(res, "") - self.master.session.expire.assert_called() + self.master.session.expire.assert_called_with() diff --git a/master/buildbot/test/unit/test_www_config.py b/master/buildbot/test/unit/test_www_config.py index cd9c5173fae..5abf7fd30cc 100644 --- a/master/buildbot/test/unit/test_www_config.py +++ b/master/buildbot/test/unit/test_www_config.py @@ -33,7 +33,7 @@ def test_render(self): rsrc.reconfigResource(master.config) res = yield self.render_resource(rsrc, '/') - _auth.maybeAutoLogin.assert_called() + _auth.maybeAutoLogin.assert_called_with(mock.ANY) exp = 'this.config = {"url": "h:/a/b/", "user": {"anonymous": true}, "auth": {"name": "NoAuth"}, "port": null}' self.assertEqual(res, exp)