From bfdb69ea11aa8476703f151c751cfb3e00c23703 Mon Sep 17 00:00:00 2001 From: Tom Prince Date: Tue, 2 Oct 2012 13:30:35 -0600 Subject: [PATCH] Better logging of errors from web change hooks. The error message was getting discarded, making debugging impossible. --- master/buildbot/status/web/change_hook.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/master/buildbot/status/web/change_hook.py b/master/buildbot/status/web/change_hook.py index ba8a2f96dc6..cc53e34bc5b 100644 --- a/master/buildbot/status/web/change_hook.py +++ b/master/buildbot/status/web/change_hook.py @@ -63,8 +63,8 @@ def render_POST(self, request): except ValueError, err: request.setResponseCode(400, err.args[0]) return err.args[0] - except Exception: - log.err(None, "Exception processing web hook.") + except Exception, e: + log.err(e, "processing changes from web hook") msg = "Error processing changes." request.setResponseCode(500, msg) return msg @@ -78,7 +78,8 @@ def render_POST(self, request): def ok(_): request.setResponseCode(202) request.finish() - def err(_): + def err(why): + log.err(why, "adding changes from web hook") request.setResponseCode(500) request.finish() d.addCallbacks(ok, err)