New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE requests returning conflicting status codes #2903

Open
tardyp opened this Issue Mar 9, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@tardyp
Member

tardyp commented Mar 9, 2017

This ticket is a migrated Trac ticket 3108

People contributed to the original ticket: @djmitche, @sa2ajj, benoit.allard@..., @tardyp
Ticket created on: Dec 11 2014
Ticket last modified on: Dec 25 2015


The request are returning a 200 status code, but in the body is a (hidden) 500.

Example:

ok
<html>
  <head><title>500 - Request did not return bytes</title></head>
  <body>
    <h1>Request did not return bytes</h1>
    <p>Request: <pre>&lt;Request at 0x60af368 method=GET uri=/sse/add/89c62c11-5652-4906-ac9d-bc5636e575c3/buildsets/748/* clientproto=HTTP/1.0&gt;</pre><br />Resource: <pre>&lt;buildbot.www.sse.[[EventResource]] instance at 0x41e0b00&gt;</pre><br />Value: <pre>None</pre></p>
  </body>
</html>

This was first seen on nine.b.n with the builds/*/* url.


Comment from: @tardyp
Date: Dec 11 2014

I think this is a false error. The request is accounted, but it returns something that twisted web does not like


Comment from: @dustin
Date: Dec 12 2014

I'm confused. From this and #1439 it sounds like this got figured out. Can we close this bug?


Comment from: @ben
Date: Dec 12 2014

@dustin, That PR (1439) is not related, I just tried to explain why the view was not dynamic as I expected with this issue, which according to @tardyp is not the correct explanation.

This issue is just about an inconsistent confusing message I saw in my logs. So far I didn't linked this behavior (500 in the body of the 200) to any malfunction directly.


Comment from: @dustin
Date: Sep 06 2015

@tardyp - I don't think we're using SSE anymore -- can this be closed up?


Comment from: @tardyp
Date: Dec 22 2015

I think sse is really practical to implement straight forward remote build triggering and waiting. I would need to provide a simple example of that in the doc


Comment from: @dustin
Date: Dec 25 2015

OK, but not a blocker to 0.9.0

@tardyp tardyp added this to the 1.0.+ milestone Mar 9, 2017

@seankelly seankelly added bug sse labels Mar 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment