New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running with --nodaemon and PID files #3012

Closed
tardyp opened this Issue Mar 9, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@tardyp
Member

tardyp commented Mar 9, 2017

This ticket is a migrated Trac ticket 3608

People contributed to the original ticket: @unknown_contributor
Ticket created on: Sep 12 2016
Ticket last modified on: Sep 12 2016


Both the master and the worker still use PID files while running with --nodaemon. I've had issues with workers running with --nodaemon not starting because of an old, stale PID file, corresponding to an actual process belonging to another user.

This can be thought to be inconsistent, and harms the writing ofreally simple non forking configuration files to manage the process through an external service manager (systemd, supervisord etc.).

It seems that the cousin twistd executable has a --pidfile argument, that can be used to mean "no pid file". This is explained notably in https://twistedmatrix.com/documents/current/core/howto/systemd.html.

We could expose that, or we could decide that --nodaemon implies no pid file.

I believe this is true in Eight and Nine, and that a fix could be easily backported
(marking this as minor, because it's easy to circumvent by putting appropriate rms in unit files or other confs)


@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Sep 16, 2017

Member

fixed by #3606

Member

tardyp commented Sep 16, 2017

fixed by #3606

@tardyp tardyp closed this in #3623 Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment