You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
People contributed to the original ticket: benoit.allard@...
Ticket created on: Feb 28 2017
Ticket last modified on: Feb 28 2017
According to the documentation, this should disable the timeout altogether.
Unfortunately, the timeout value is given to the worker only if the value evaluates to 'True-ish'. The worker on its side, when not given a value uses 120sec. Making the timeout=None useless.
I think the problem exists in buildbot/master/steps/worker.py, where on line 124 we have: def __init__(self, src, dest, timeout=None, maxTime=None, **kwargs):
where the timeout defaults to None. Later, in the start function (lines 135 and 136), the truthiness of timeout is evaluated: if self.timeout: args['timeout'] = self.timeout
Later, the get statement in fs.py that is modified by the old pull statement finds args['timeout'] empty, and sets timeout to 120.
The solution I can think of is to set the default to 120 (to be in line with documentation) and remove the if statement. The tests would also need to be updated, as they expect timeout to be None if no argument is passed.
This ticket is a migrated Trac ticket 3669
People contributed to the original ticket:
benoit.allard@...
Ticket created on:
Feb 28 2017
Ticket last modified on:
Feb 28 2017
According to the documentation, this should disable the timeout altogether.
Unfortunately, the timeout value is given to the worker only if the value evaluates to 'True-ish'. The worker on its side, when not given a value uses 120sec. Making the timeout=None useless.
Comment from: @ben
Date:
Feb 28 2017
The workaround is to use a bigger value, like 1200.
The text was updated successfully, but these errors were encountered: