New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerLatentWorker: pull specified image if it is not yet on the system #3071

Closed
noc0lour opened this Issue Mar 24, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@noc0lour
Contributor

noc0lour commented Mar 24, 2017

This is merely an enhancement, but it would be nice if the specified image is pulled from dockerhub if it is not on yet on the host system.
This should be pretty easy to accomplish using docker-py, but I don't know if this a desired feature.

@Frodox

This comment has been minimized.

Show comment
Hide comment
@Frodox

Frodox Mar 24, 2017

Member

Generally +1, but I'm voting for config-option also, to disable/enable behavior. It is not always desired, because sometime LatentWorker should take identical custom docker-image, not latest one from dockerHub. And in case there is no one - host is bit miss-configured and it s an error :)

Member

Frodox commented Mar 24, 2017

Generally +1, but I'm voting for config-option also, to disable/enable behavior. It is not always desired, because sometime LatentWorker should take identical custom docker-image, not latest one from dockerHub. And in case there is no one - host is bit miss-configured and it s an error :)

@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Mar 24, 2017

Member

in my understanding, this is already the case. If its not, this code is pretty simple, and you should easily be able to fix it

Member

tardyp commented Mar 24, 2017

in my understanding, this is already the case. If its not, this code is pretty simple, and you should easily be able to fix it

@noc0lour

This comment has been minimized.

Show comment
Hide comment
@noc0lour

noc0lour Mar 24, 2017

Contributor

Yeah, I looked into the code yesterday but didn't have the time to figure it out, also a spotted another bug with docker images, but that one I can fix myself

Contributor

noc0lour commented Mar 24, 2017

Yeah, I looked into the code yesterday but didn't have the time to figure it out, also a spotted another bug with docker images, but that one I can fix myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment