Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
BuildMaster.addChange drops data for fields who were renamed.. #3191
If addChange is called with when_timestamp and not when, then kwargs['when_timestamp'] = handle_deprec("when", "when_timestamp") will set it to None, and then the data in the db will just be the time the change was processed.
The fix is:
Test need to be updated for this. Don't have time at the moment to do so, but want to make sure this is not lost.
Note this affects most (if not all) webhooks. (But not github poller's it seems)