New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2 logout + login fails on Firefox #3306

Closed
tardyp opened this Issue Jun 9, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@tardyp
Member

tardyp commented Jun 9, 2017

as discussed in #3302

On firefox, the second login with oauth keeps the user in anonymous.

Needs to investigate further

@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Jun 9, 2017

Member

So problem comes from the fact that during login procedure the ws connection is closed, and the JS in charge of detecting that triggers, which triggers polling of / and once a success full xhr on / is done, the JS will reload the page. In the middle of that the github oauth is still going out, but is then interrupted by that JS reload.

image

We need to make sure we disable all angularJS callbacks before going to login page.

Member

tardyp commented Jun 9, 2017

So problem comes from the fact that during login procedure the ws connection is closed, and the JS in charge of detecting that triggers, which triggers polling of / and once a success full xhr on / is done, the JS will reload the page. In the middle of that the github oauth is still going out, but is then interrupted by that JS reload.

image

We need to make sure we disable all angularJS callbacks before going to login page.

@tardyp tardyp referenced this issue Jun 9, 2017

Merged

Set the forward flags on the nginx example config #3302

1 of 3 tasks complete
@s0undt3ch

This comment has been minimized.

Show comment
Hide comment
@s0undt3ch

s0undt3ch Jun 9, 2017

Contributor

Makes sense now.

Contributor

s0undt3ch commented Jun 9, 2017

Makes sense now.

@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Jun 9, 2017

Member

@s0undt3ch please see the fix in #3307. this fixes the problem for me on nine.buildbot.net. Please report back your own results.

Member

tardyp commented Jun 9, 2017

@s0undt3ch please see the fix in #3307. this fixes the problem for me on nine.buildbot.net. Please report back your own results.

@s0undt3ch

This comment has been minimized.

Show comment
Hide comment
@s0undt3ch

s0undt3ch Jun 9, 2017

Contributor

#3307 fixes the problem I was experiencing, Thanks!

Contributor

s0undt3ch commented Jun 9, 2017

#3307 fixes the problem I was experiencing, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment