New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineBoundaryFinder struggles when a script does not output new lines #3517

Closed
tardyp opened this Issue Aug 14, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@tardyp
Member

tardyp commented Aug 14, 2017

<aj355> I finally figured out what was causing the performance issue (https://github.com/buildbot/buildbot/issues/3444)
06:22:50 A<aj355> We have a (innocent looking) build step which copies ~600,000 files (in 20 minutes) from one location to another on the worker machine. This step is run once in a while (that’s why i was seeing performance issue intermittently). The performance issue happens exactly when this step is run.
06:22:50 A<aj355> This step prints a lot of data very quickly on console in a progress bar kind of manner (it keeps over-writing the console output by writing \b (backspace)

A script could indeed be showing status report using terminal control flow (or ugly \b) instead of \r.

This could be a DOS issue if a evil script output lots of data without newlines, then master will crash with out of memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment