New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildbot should check for duplicates in addURL #3554

Closed
aj062 opened this Issue Aug 23, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@aj062

aj062 commented Aug 23, 2017

In a step if we call self.addURL() multiple times with same URL, buildbot doesn't check if URL is already added, and adds the duplicate URL. Buildbot should check if the URL is already added before adding the URL.

This happens when a script parses a lot of output and generate links for various things. We can manually maintain a list ourself and check for duplicates before calling addURL(), but it feels so basic that buildbot should be doing this check instead of callers of addURL() checking for duplicates.

@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Aug 28, 2017

Member

feel free to add this improvement.

Member

tardyp commented Aug 28, 2017

feel free to add this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment