New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.9.10]: SVN.purge fails when modified files contain non-ascii characters #3576

Closed
cmumford opened this Issue Sep 4, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@cmumford

cmumford commented Sep 4, 2017

Version info:

  • Python version: 2.7.9
  • Buildbot version: 0.9.10
  • Twisted version: 17.5.0
  • Client: macOS Sierra

I have a master configuration with the following:

steps.SVN(name="SVN Source",                                                                                                                  
          repourl="http://the.host.com/svn/repository",                                                            
          mode='full', method='fresh')

with a modified file as so:

<entry
   path="Path/To/Content/Developers/François">
<wc-status
   item="unversioned"
   props="none">
</wc-status>
</entry>

Fails as so:

Traceback (most recent call last):
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 653, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1442, in gotResult
    _inlineCallbacks(r, g, deferred)
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1384, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/twisted/python/failure.py", line 393, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
--- <exception caught here> ---
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/buildbot/process/buildstep.py", line 575, in startStep
    self.results = yield self.run()
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1386, in _inlineCallbacks
    result = g.send(result)
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/buildbot/process/buildstep.py", line 705, in run
    results = yield self._start_deferred
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1384, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/twisted/python/failure.py", line 393, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/buildbot/steps/source/svn.py", line 131, in mode_full
    yield self.fresh()
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 653, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/home/build/buildbot/sandbox/local/lib/python2.7/site-packages/buildbot/steps/source/svn.py", line 356, in parseAndRemove
    filename = self.workdir + '/' + str(filename)
exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\u0327' in position 42: ordinal not in range(128)

tardyp added a commit to tardyp/buildbot that referenced this issue Sep 5, 2017

@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Sep 5, 2017

Member

@cmumford can you please try the fix in #3579 ?

Member

tardyp commented Sep 5, 2017

@cmumford can you please try the fix in #3579 ?

@cmumford

This comment has been minimized.

Show comment
Hide comment
@cmumford

cmumford Sep 6, 2017

Verified - thanks for the quick fix.

cmumford commented Sep 6, 2017

Verified - thanks for the quick fix.

@seankelly seankelly closed this Sep 11, 2017

@seankelly

This comment has been minimized.

Show comment
Hide comment
@seankelly

seankelly Sep 27, 2017

Member

I closed this before the PR was actually merged so reopening.

Member

seankelly commented Sep 27, 2017

I closed this before the PR was actually merged so reopening.

@seankelly seankelly reopened this Sep 27, 2017

@tardyp tardyp closed this in #3579 Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment