New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console UI jumps to top of page when you click on a build #3657

Closed
uglycoyote opened this Issue Sep 27, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@uglycoyote
Contributor

uglycoyote commented Sep 27, 2017

If the console view is long enough that you have to scroll down, when I click on a bubble (to view a build summary) it automatically scrolls back to the top of the console table. This is annoying if you want to view a bunch of summaries that are all side by side but somewhere way down the page.

@tardyp tardyp changed the title from Console UI jumps to top of page when you click on a bubble to Console UI jumps to top of page when you click on a build Oct 10, 2017

@uglycoyote

This comment has been minimized.

Show comment
Hide comment
@uglycoyote

uglycoyote Dec 14, 2017

Contributor

This issue goes away if you remove the css rule that sets height: 100% on body.

I got this hint from this thread

It is not clear to me what the purpose of setting html and body to have a height of 100%, shouldn't they just be as tall as the content that they contain? Perhaps this is some semi-standard css trick copied from bootstrap somewhere? I gathered that it may have something to do with making "sticky footers" work, but as far as I know those are not used anywhere in buildbot's UI. I didn't see any problems so far running without the height: 100%. Will propose a pull request with this change.

Contributor

uglycoyote commented Dec 14, 2017

This issue goes away if you remove the css rule that sets height: 100% on body.

I got this hint from this thread

It is not clear to me what the purpose of setting html and body to have a height of 100%, shouldn't they just be as tall as the content that they contain? Perhaps this is some semi-standard css trick copied from bootstrap somewhere? I gathered that it may have something to do with making "sticky footers" work, but as far as I know those are not used anywhere in buildbot's UI. I didn't see any problems so far running without the height: 100%. Will propose a pull request with this change.

@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Dec 14, 2017

Member

I am not sure as well. If that removal does not introduce any other ui regression. go for it!

Member

tardyp commented Dec 14, 2017

I am not sure as well. If that removal does not introduce any other ui regression. go for it!

@uglycoyote

This comment has been minimized.

Show comment
Hide comment
@uglycoyote

uglycoyote Mar 28, 2018

Contributor

Fixed in pull request #3858

Contributor

uglycoyote commented Mar 28, 2018

Fixed in pull request #3858

@uglycoyote uglycoyote closed this Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment