New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST args in GitLab push notification do not work #3720

Closed
pmatos opened this Issue Oct 27, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@pmatos
Contributor

pmatos commented Oct 27, 2017

This is fundamentally the same problem we had at #3506 (@rodrigc). In Python3, some strings are now byte strings and are not identified properly by Buildbot.

In this case, I have a local gitlab instance with the webhook for push events: https://mybuildbot/change_hook/gitlab?project=lthmb.

However, when I test this the Buildbot logs show no project parameter set:

2017-10-27 18:15:14+0200 [-] injected change Change(revision='2afc1ab3ab28980db47d64714852aa0d586be7f9', who='Paulo Matos <pmatos@linki.tools>', branch='master', comments="Merge branch 'foobar'\n", when=1506599131, category='push', project='', repository='git@linki:pmatos/lthmb.git', codebase='')

I went ahead and printed the request received from gitlab in www/hooks/gitlab.py and noticed that request.args in getChanges are byte strings: 2017-10-27 18:15:14+0200 [-] {b'project': [b'lthmb']}

I think in Buildbot nine with Py3 we might need string conversion here.

pmatos added a commit to pmatos/buildbot that referenced this issue Oct 27, 2017

Transform arguments from bytes to strings.
This change works for me locally. Transform bytes in rest args to normal strings. Fixes buildbot#3720.

@rodrigc rodrigc closed this in #3721 Nov 2, 2017

rodrigc added a commit that referenced this issue Nov 2, 2017

Merge pull request #3721 from pmatos/patch-1
Transform arguments from bytes to strings.

Fixes #3720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment