New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2LatentWorker ignores tags parameter when spot_instance is True #3739

Closed
morrone opened this Issue Nov 7, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@morrone
Contributor

morrone commented Nov 7, 2017

Currently EC2LatentWorker only sets EC2 Tags on an instance when spot_instance is False. When spot_instance is True, the tags parameter is ignored.

It looks like it is any easy fix to move the call to self.instance.create_tags() into _wait_for_instance(), and then it will apply to both normal and spot instances. I'll submit a patch.

@tardyp tardyp closed this in 04ad929 Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment