Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
In buildbot web UI, inconsistent use of "pointer" mouse cursor #3795
We have had feedback from some of our users that it's difficult to know which things in the Buildbot UI are supposed to be clickable and which ones are not.
When you mouse-over this "..." yellow rectangle, the cursor changes to "pointer", leading the user to believe that they could interact with the element by clicking on it. It actually does nothing when you click on it. (User feedback indicates that the user is unsure that nothing happened, maybe something happened that they just did not notice.)
By contrast the green rectangle next to it is actually a clickable link to the builder which triggered. Both rectangles use the pointer cursor but only one is clickable.
On the other hand, on the "Builders" page there is an example of something which is clickable but does not use the "pointer" style
Looking in why the yellow rectangle changes to "pointer" I see that there is a css rule which says
and the jade code which causes the yellow rectangle to appear is
This css rule which says "all labels should use cursor:pointer" seems wrong, since clearly all labels are not clickable.
I'm tempted to submit a pull request to just remove this css rule, but I'm not sure what negative impact it would have.
For the green clickable rectangle, the code is:
the green (clickable) rectangle uses this code, so would probably have the
and so it would probably still invoke the pointer icon since it has the explicit
But there are probably other places where the "label" style is used for something that's clickable using ng-click and removing
My suggestion would be to have a more explicitly named style:
and only apply it to things which are clickable but are not already using
Hi @uglycoyote I think you did a good investigation already and you are very near a working PR.
You can watch the web dev tutorial here for a quick setup:
Then, you can edit https://github.com/buildbot/buildbot/blob/master/www/base/src/styles/styles.less#L28 to add the .clickable snippet.