New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnicodeEncodeError in SVNPoller (0.9.15) #3865

Closed
cmumford opened this Issue Jan 2, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@cmumford

cmumford commented Jan 2, 2018

I just upgraded from 0.9.11 to 0.9.15, but this may not be a new issue. The SVN log message in r663 is: "Adding some of François's stuff".

2018-01-02 22:50:18+0000 [-] SVNPoller: _process_changes 662 .. 663
2018-01-02 22:50:18+0000 [-] Adding change revision 663
2018-01-02 22:50:18+0000 [-] SVNPoller: Error in  while polling
        Traceback (most recent call last):
          File "/home/chris/continuous-build/buildbot/buildbotvenv/lib/python3.4/site-packages/twisted/internet/_baseprocess.py", line 64, in maybeCallProcessEnded
            proto.processEnded(Failure(reason))
          File "/home/chris/continuous-build/buildbot/buildbotvenv/lib/python3.4/site-packages/twisted/internet/utils.py", line 93, in processEnded
            self.deferred.callback(self.s.getvalue())
          File "/home/chris/continuous-build/buildbot/buildbotvenv/lib/python3.4/site-packages/twisted/internet/defer.py", line 459, in callback
            self._startRunCallbacks(result)
          File "/home/chris/continuous-build/buildbot/buildbotvenv/lib/python3.4/site-packages/twisted/internet/defer.py", line 567, in _startRunCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/home/chris/continuous-build/buildbot/buildbotvenv/lib/python3.4/site-packages/twisted/internet/defer.py", line 653, in _runCallbacks
            current.result = callback(current.result, *args, **kw)
          File "/home/chris/continuous-build/buildbot/buildbotvenv/lib/python3.4/site-packages/buildbot/changes/svnpoller.py", line 360, in create_changes
            path = path.encode("ascii")
        builtins.UnicodeEncodeError: 'ascii' codec can't encode character '\u0327' in position 43: ordinal not in range(128)

2018-01-02 22:51:11+0000 [-] SVNPoller: polling
@cmumford

This comment has been minimized.

Show comment
Hide comment
@cmumford

cmumford Jan 2, 2018

Looks like the cause is the file path not the comment:

/UE4/StarryExpanse/Content/Developers/François/

cmumford commented Jan 2, 2018

Looks like the cause is the file path not the comment:

/UE4/StarryExpanse/Content/Developers/François/
@rodrigc

This comment has been minimized.

Show comment
Hide comment
@rodrigc

rodrigc Jan 3, 2018

Collaborator

Can you provide the full raw log of r663 in XML format?

something like:

svn log --xml -r663
Collaborator

rodrigc commented Jan 3, 2018

Can you provide the full raw log of r663 in XML format?

something like:

svn log --xml -r663
@rodrigc

This comment has been minimized.

Show comment
Hide comment
@rodrigc

rodrigc Jan 3, 2018

Collaborator

According to http://svnbook.red-bean.com/en/1.7/svn.advanced.l10n.html , Subversion internally stores paths encoded as UTF-8, so we need to improve the code in buildbot, and maybe
add some tests with some paths which have non-ASCII characters.

Collaborator

rodrigc commented Jan 3, 2018

According to http://svnbook.red-bean.com/en/1.7/svn.advanced.l10n.html , Subversion internally stores paths encoded as UTF-8, so we need to improve the code in buildbot, and maybe
add some tests with some paths which have non-ASCII characters.

@cmumford

This comment has been minimized.

Show comment
Hide comment
@cmumford

cmumford Jan 3, 2018

I see @tardyp fixed this already. Here's the log, and I'll test it tonight.

svn log --xml --verbose -r663 file:///path/to/repo
<?xml version="1.0" encoding="UTF-8"?>
<log>
<logentry
   revision="663">
<author>philip</author>
<date>2018-01-02T22:50:09.157379Z</date>
<paths>
<path
   action="A"
   prop-mods="false"
   text-mods="false"
   kind="dir">/UE4/StarryExpanse/Content/Developers/François</path>
<path
   kind="dir"
   action="A"
   prop-mods="false"
   text-mods="false">/UE4/StarryExpanse/Content/Developers/François/Collections</path>
<path
   kind="dir"
   action="A"
   prop-mods="false"
   text-mods="false">/UE4/StarryExpanse/Content/Developers/François/Misc</path>
<path
   action="A"
   prop-mods="true"
   text-mods="true"
   kind="file">/UE4/StarryExpanse/Content/Developers/François/Misc/LUT_Fall.uasset</path>
<path
   prop-mods="false"
   text-mods="false"
   kind="dir"
   action="A">/UE4/StarryExpanse/Content/Developers/François/TestMaps</path>
<path
   action="A"
   prop-mods="true"
   text-mods="true"
   kind="file">/UE4/StarryExpanse/Content/Developers/François/TestMaps/TestGehnLab.umap</path>
</paths>
<msg>Adding some of François's stuff</msg>
</logentry>
</log>

cmumford commented Jan 3, 2018

I see @tardyp fixed this already. Here's the log, and I'll test it tonight.

svn log --xml --verbose -r663 file:///path/to/repo
<?xml version="1.0" encoding="UTF-8"?>
<log>
<logentry
   revision="663">
<author>philip</author>
<date>2018-01-02T22:50:09.157379Z</date>
<paths>
<path
   action="A"
   prop-mods="false"
   text-mods="false"
   kind="dir">/UE4/StarryExpanse/Content/Developers/François</path>
<path
   kind="dir"
   action="A"
   prop-mods="false"
   text-mods="false">/UE4/StarryExpanse/Content/Developers/François/Collections</path>
<path
   kind="dir"
   action="A"
   prop-mods="false"
   text-mods="false">/UE4/StarryExpanse/Content/Developers/François/Misc</path>
<path
   action="A"
   prop-mods="true"
   text-mods="true"
   kind="file">/UE4/StarryExpanse/Content/Developers/François/Misc/LUT_Fall.uasset</path>
<path
   prop-mods="false"
   text-mods="false"
   kind="dir"
   action="A">/UE4/StarryExpanse/Content/Developers/François/TestMaps</path>
<path
   action="A"
   prop-mods="true"
   text-mods="true"
   kind="file">/UE4/StarryExpanse/Content/Developers/François/TestMaps/TestGehnLab.umap</path>
</paths>
<msg>Adding some of François's stuff</msg>
</logentry>
</log>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment