REST API wrong behaviour

[vladbogo]

Hi,

I have a question regrading the REST API. We are trying to get a list of the last changes for a particular branch.

However, using https://buildbot.mariadb.org/api/v2/changes?branch=10.1&order=-changeid&limit=10 does not return the last 10 changes for the 10.1 branch. Is this the expected behaviour? Based on the documentation I would assume that this would return the last 10 changes for branch 10.1. If the limit argument is increased, more changes start to appear.

Things get a lot more confusing when deleting the "order" argument https://buildbot.mariadb.org/api/v2/changes?branch=10.1&limit=10 when the request times out and the buildbot is unresponsive for several minutes. Any thoughts on this? Is there any sort of cache used?

Thanks!

[vladbogo]

Any updates?

[tardyp]

Indeed, this is a bug, we do not support limit and filtering with the current code.

as per this code, the limit is done here, but only when order is -changeid

buildbot/master/buildbot/data/changes.py

Line 85 in 81d693a

changes = yield self.master.db.changes.getRecentChanges(resultSpec.limit)

This should rather be implemented like in the builds endpoint:

buildbot/master/buildbot/data/builds.py

Line 161 in 81d693a

builds = yield self.master.db.builds.getBuilds(

where resultSpec is passed to the db api

and then used with a generic database query generation

buildbot/master/buildbot/db/builds.py

Line 147 in 81d693a

return resultSpec.thd_execute(conn, q, self._builddictFromRow)

would you like to fix this code?

[vladbogo]

Thanks for your answer. I will look into it and try to fix it.