Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose internal testing framework for writing unit tests for steps #6291

Merged
merged 4 commits into from Nov 11, 2021

Conversation

p12tic
Copy link
Member

@p12tic p12tic commented Nov 5, 2021

This PR exposes part of our internal test framework and enables the users to write unit tests for steps.

We currently mark the API as experimental because we may still discover improvements of how to expose this.

I'm not completely sure if buildbot.test.expect is the best place for command expectations. Maybe they should be moved to buildbot.test.steps.

cc @tardyp

Contributor Checklist:

  • [n/a] I have updated the unit tests
  • I have created a file in the newsfragments directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #6291 (6b23422) into master (1c72c62) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6291      +/-   ##
==========================================
- Coverage   91.92%   91.91%   -0.02%     
==========================================
  Files         334      334              
  Lines       37542    37542              
==========================================
- Hits        34511    34505       -6     
- Misses       3031     3037       +6     
Impacted Files Coverage Δ
master/buildbot/util/queue.py 90.69% <0.00%> (-5.82%) ⬇️
worker/buildbot_worker/tunnel.py 88.13% <0.00%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c72c62...6b23422. Read the comment docs.

@p12tic p12tic merged commit bfdb0a4 into buildbot:master Nov 11, 2021
@p12tic p12tic deleted the tests-api branch November 11, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant