New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git poll 3 #1010
Git poll 3 #1010
Conversation
The make the ``branches`` argument accept either ``True`` to poll all branches, or a callable to filter the remote branches.
Yes, this looks better to me. Let's see what @tomprince says. |
@tomprince ping. |
@djmitche No answer from @tomprince . I'm quite keen to make sure this time this change doesn't get bit-rotted. I've been using this feature for the past few weeks and it seems to be working correctly. So I would say it's working well enough to merge. |
OK, sounds good. It can always be changed later (sorta)! |
@djmitche: Thank you! |
No problem - thanks for the poke, as I had indeed forgotten |
Noticed a few problems in gitpoller. I noticed whenever I try to get a branch with something like Another issue that came us is stemmed from the problem i listed above. When it tries to do an initial git clone, it fails because the branch isnt correct. For example |
Hi @akamel001, We are working on this in #1069 and it should be merged into the 0.8.9 branch and master today. |
Ah perfect, thanks! |
This pull request supersedes #1009.
This branch improves upon the previous branch in the following ways:
refs/heads/mybranch
instead ofmybranch
), for compatibility with earlier versions of the implementation. @djmitche Can you confirm that this is a valid correction to this issue?