Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
(WIP) keep HTML logs out of buildstatus pickles #1077
I tried to solve the problem by making the class inherit from
In it's current implementation,
We'll definitely need tests for this change, including the ability to import old pickles and have them work correctly.
If TestRealDB still segfaults for the master branch, then I suspect there's a problem with your Python install, probably around the SQLite support. We can try and help in #buildbot on freenode.
Okay, I removed the conditional embedding of the logfiles in the pickle.
For testing the unpickling of old html logs I checked out master, manually pickled a logfile and pasted the base64 encoded string into the test.
Let me know if you want me to rebase the PR!
PS: Yup, it was SQLite.