Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansicodes and html escaping in logs #2114

Merged
merged 3 commits into from Apr 12, 2016

Conversation

@tardyp
Copy link
Member

commented Apr 11, 2016

fix for http://trac.buildbot.net/ticket/3061

Here is how it looks like with a gulp build:

image

@mention-bot

This comment has been minimized.

Copy link

commented Apr 11, 2016

By analyzing the blame information on this pull request, we identified @djmitche, @tothandras and @sa2ajj to be potential reviewers

@AppVeyorBot

This comment has been minimized.

Copy link

commented Apr 11, 2016

@codecov-io

This comment has been minimized.

Copy link

commented Apr 11, 2016

Current coverage is 84.26%

Merging #2114 into master will decrease coverage by -0.01% as of adac0c0

@@            master   #2114   diff @@
======================================
  Files          333     332     -1
  Stmts        31970   31955    -15
  Branches         0       0       
  Methods          0       0       
======================================
- Hit          26943   26928    -15
  Partial          0       0       
  Missed        5027    5027       

Review entire Coverage Diff as of adac0c0


Uncovered Suggestions

  1. +0.11% via ...ot/status/builder.py#384...417
  2. +0.09% via ...ot/status/builder.py#456...484
  3. +0.09% via ...dbot/changes/mail.py#480...507
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@AppVeyorBot

This comment has been minimized.

Copy link

commented Apr 12, 2016

@tardyp tardyp force-pushed the tardyp:htmlescape branch from 6631b8f to 7b9edd8 Apr 12, 2016

@AppVeyorBot

This comment has been minimized.

Copy link

commented Apr 12, 2016

@sa2ajj sa2ajj merged commit 20cac3f into buildbot:master Apr 12, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch coverage not affected
Details
codecov/project 84.26% (target 80.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.