Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get username from HTTP request headers when buildbot is served by frontend webserver #266

Merged
merged 2 commits into from Oct 9, 2011

Conversation

Projects
None yet
2 participants
@paroga
Copy link
Contributor

commented Oct 6, 2011

This change is a friend of #45.

Thanks to dionorgua for the documentation I reused in the first commit.

paroga added some commits Oct 6, 2011

Add support for getting HTTP username
Sometimes it may be useful to run WebStatus through standalone
webserver that may be configured for HTTP authentication (for
example in corporate network it may use LDAP to authenticate users).
In such cases it's reasonable to trust webserver and instead of
asking for username and password for actions like trigger build,
just get username from HTTP headers.
Hide "username" field when HTTP authentication is enabled
In case if username is already known from HTTP request headers, there
is no sense to ask user to enter it again. This adds needUserForm
method to Authz class and modifies the authFormIfNeeded template to
hide the username field if not needed.

@djmitche djmitche merged commit 31ff088 into buildbot:master Oct 9, 2011

mzdaniel pushed a commit to mzdaniel/buildbot that referenced this pull request Aug 2, 2013

Solomon Hykes
Merge pull request buildbot#266 from dotcloud/do_not_log_stopped_cont…
…ainer

Do not log non-running containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.