Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Webui changes #278
This has run in prod for several month now, 15 maintainers are using it in a daily basis, and do not have any known bugs anymore.
This is looking great. A few comments:
First, merged to trunk, this fails with many errors like
[ERROR] Traceback (most recent call last): File "/home/dustin/code/buildbot/t/buildbot/master/buildbot/test/unit/test_status_web_authz_Authz.py", line 184, in test_needUserForm_http_False assert not z.needUserForm('forceBuild') exceptions.AttributeError: 'Authz' object has no attribute 'needUserForm' buildbot.test.unit.test_status_web_authz_Authz.TestAuthz.test_needUserForm_http_False
can you fix those up?
The new scheduler will need unit tests. It'd be great to name it
In the docs, the
There are a number of "todo" items in this series of commits - please either complete them, or remove the TODO items. There's also at least one debug print (in
I suspect that the if/elif with
I'm not sure how wise it is to cross the namespaces of properties and request arguments (the
The scheduler should probably use the
As for the Auth/Authz changes, I like the design quite a bit, although it does not allow me to login - entering a valid username/password brings me to a new page with the same login form. An invalid username/password will take me to the authfail page.
I've also pushed a version with some minor editing to my 'pull278' branch - https://github.com/djmitche/buildbot/commits/pull278. These edits are primarily to make pyflakes pass (removing unused imports, etc.), add some whitespace to make the code more pep8-compliant, wrap long lines, and correct some minor English errors - nothing substantial in the code.
I fixed some bugs by running the unit tests, can you retry, and give a
All the unittest are passing, and I have made some change to the default config for use new authz and ForceScheduler.
Should be ready for merge...
Excellent! A few remaining issues, and hopefully I won't take 6 days to review the next round (bearing in mind there was a US holiday in there..):
On Sat, Nov 26, 2011 at 5:20 PM, Dustin J. Mitchell
If you are authenticated, that is the expected behavior. If you are
yes you are right, the doc was noised by the class definitions. I hope
This cannot happen when not forcing all. Contract from the calling code.
Hope this is the last version. I'm very happy about it. I think this
This looks great - the last round of patch has added significant polish! I'll get this merged, and add some notes to the release notes, too.
This is a great improvement to Buildbot, and will be enough on its own to justify a 0.8.6 release. There are a few more changes about ready to land, so once those are in place, we'll ship it!