Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:revlinks #280

Merged
merged 8 commits into from Dec 30, 2011

Conversation

Projects
None yet
2 participants
@tomprince
Copy link
Member

commented Nov 7, 2011

This still needs docs and tests, but comments welcome.

@djmitche

This comment has been minimized.

Copy link
Member

commented Nov 14, 2011

Looks good -- keep at it!

tomprince added some commits Nov 7, 2011

Implement some default revlink functions.
In particular, github and sourceforge git are implemented so far.
Move buildbot.status.revlinks to buildbot.revlinks.
Otherwise, when buildbot.config tries to import default_revlink_matcher,
a circular import is created.
Document that c['revlink'] has a reasonable deafult.
It probably doesn't have enough defaults to be reasonable yet,
but we will just pretend we do for now, in the documentation.
@tomprince

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2011

@djimtche: ping

@djmitche

This comment has been minimized.

Copy link
Member

commented Nov 26, 2011

This still needs tests for RevlinkMatch (pyflakes tells me it's imported in test_revlinks, but not used). Feel free to merge it yourself, with those tests added and with a pyflakes run.

I made some other, minor, edits in djmitche@pull280, if you'd like to incorporate that.

@tomprince

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2011

I think this is ready to go in. GitwebMatch isn't documented, but it isn't obvious to me how to document it.

I left the comment about the default at the top, because it is my hope that eventually, most people won't need to specify it, since the default is good enough.

@djmitche djmitche merged commit ba29d78 into buildbot:master Dec 30, 2011

@djmitche

This comment has been minimized.

Copy link
Member

commented Dec 30, 2011

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.