New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3 issue with displaying the properties in API call #3418

Merged
merged 6 commits into from Jul 10, 2017

Conversation

Projects
None yet
3 participants
@danieltcv

danieltcv commented Jul 6, 2017

When running buildbot with python3, the following API call:

/api/v2/builders//builds&property=*

or any property filter for that matter does not return the expected set of
filters but instead returns an empty dictionary {}.

The fix is to compare the right types of variables - string vs binary.
In python 2 the b'' prefix is ignored so it shouldn't break changes there.

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragment directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

Daniel Tsvetkov added some commits Jul 6, 2017

@rodrigc

This comment has been minimized.

Show comment
Hide comment
@rodrigc

rodrigc Jul 6, 2017

Collaborator

testPipeString is failing after this change. Can you fix the test as part of your commit?

Collaborator

rodrigc commented Jul 6, 2017

testPipeString is failing after this change. Can you fix the test as part of your commit?

Daniel Tsvetkov
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 7, 2017

Codecov Report

Merging #3418 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
+ Coverage   88.28%   88.28%   +<.01%     
==========================================
  Files         323      323              
  Lines       33649    33651       +2     
==========================================
+ Hits        29706    29708       +2     
  Misses       3943     3943
Impacted Files Coverage Δ
master/buildbot/data/resultspec.py 90.98% <100%> (ø) ⬆️
master/buildbot/process/buildstep.py 90.81% <0%> (+0.01%) ⬆️
master/buildbot/reporters/notifier.py 96.35% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d44f03...0968ab3. Read the comment docs.

codecov bot commented Jul 7, 2017

Codecov Report

Merging #3418 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
+ Coverage   88.28%   88.28%   +<.01%     
==========================================
  Files         323      323              
  Lines       33649    33651       +2     
==========================================
+ Hits        29706    29708       +2     
  Misses       3943     3943
Impacted Files Coverage Δ
master/buildbot/data/resultspec.py 90.98% <100%> (ø) ⬆️
master/buildbot/process/buildstep.py 90.81% <0%> (+0.01%) ⬆️
master/buildbot/reporters/notifier.py 96.35% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d44f03...0968ab3. Read the comment docs.

@danieltcv

This comment has been minimized.

Show comment
Hide comment
@danieltcv

danieltcv commented Jul 7, 2017

@rodrigc done

Show outdated Hide outdated master/buildbot/newsfragments/.bugfix Outdated
@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Jul 10, 2017

Member

@danieltcv can you please fix that news fragment, so that we can merge it?

Member

tardyp commented Jul 10, 2017

@danieltcv can you please fix that news fragment, so that we can merge it?

Daniel Tsvetkov and others added some commits Jul 10, 2017

Daniel Tsvetkov

@tardyp tardyp merged commit e50e00e into buildbot:master Jul 10, 2017

32 checks passed

QuantifiedCode No new issues introduced.
Details
bb Build done.
Details
bb/coverage/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/coverage/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/docs/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/flake8/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/flake8/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/isort/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/js/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/pylint/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/smokes/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/smokes/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:14.0.2/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.4.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.5.0/sqla:0.8.0/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.5.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:mysql+mysqldb://travis@127.0.0.1/bbtest Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:sqlite:////tmp/test_db.sqlite Build done.
Details
bb/trial/3.4/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/3.6/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.6/tw:14.0.2/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.6/tw:15.4.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:10.2.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:11.1.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:12.2.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:13.2.0/sqla:latest/db:sqlite:// Build done.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 88.28%)
Details
codecov/project 88.28% (+<.01%) compared to 0d44f03
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment