New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name management in NotifierBase #3450

Merged
merged 2 commits into from Jul 22, 2017

Conversation

Projects
None yet
2 participants
@tardyp
Member

tardyp commented Jul 17, 2017

Name is automatically managed by buildbot service and is not passed to
checkConfig/reconfigureService, so that the notifier name is never
actually overriden

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragment directory (and read the README.txt in that directory)
Fix name management in NotifierBase
Name is automatically managed by buildbot service and is not passed to
checkConfig/reconfigureService, so that the notifier name is never
actually overriden
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 17, 2017

@tardyp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @macdems, @rodrigc and @perher to be potential reviewers.

mention-bot commented Jul 17, 2017

@tardyp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @macdems, @rodrigc and @perher to be potential reviewers.

1 similar comment
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 17, 2017

@tardyp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @macdems, @rodrigc and @perher to be potential reviewers.

mention-bot commented Jul 17, 2017

@tardyp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @macdems, @rodrigc and @perher to be potential reviewers.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 17, 2017

Codecov Report

Merging #3450 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3450      +/-   ##
==========================================
+ Coverage   88.28%   88.35%   +0.07%     
==========================================
  Files         323      323              
  Lines       33668    33854     +186     
==========================================
+ Hits        29724    29912     +188     
+ Misses       3944     3942       -2
Impacted Files Coverage Δ
master/buildbot/reporters/pushjet.py 95.74% <ø> (ø) ⬆️
master/buildbot/reporters/pushover.py 94.82% <ø> (ø) ⬆️
master/buildbot/reporters/mail.py 94.08% <100%> (ø) ⬆️
master/buildbot/reporters/notifier.py 96.37% <100%> (+0.01%) ⬆️
master/buildbot/data/base.py 94.69% <0%> (-0.92%) ⬇️
master/buildbot/db/base.py 97.82% <0%> (-0.9%) ⬇️
master/buildbot/data/builders.py 96.87% <0%> (-0.14%) ⬇️
master/buildbot/data/builds.py 99.3% <0%> (+0.32%) ⬆️
master/buildbot/db/builders.py 100% <0%> (+1.28%) ⬆️
master/buildbot/data/steps.py 99.01% <0%> (+2.81%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08cf306...3776a03. Read the comment docs.

codecov bot commented Jul 17, 2017

Codecov Report

Merging #3450 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3450      +/-   ##
==========================================
+ Coverage   88.28%   88.35%   +0.07%     
==========================================
  Files         323      323              
  Lines       33668    33854     +186     
==========================================
+ Hits        29724    29912     +188     
+ Misses       3944     3942       -2
Impacted Files Coverage Δ
master/buildbot/reporters/pushjet.py 95.74% <ø> (ø) ⬆️
master/buildbot/reporters/pushover.py 94.82% <ø> (ø) ⬆️
master/buildbot/reporters/mail.py 94.08% <100%> (ø) ⬆️
master/buildbot/reporters/notifier.py 96.37% <100%> (+0.01%) ⬆️
master/buildbot/data/base.py 94.69% <0%> (-0.92%) ⬇️
master/buildbot/db/base.py 97.82% <0%> (-0.9%) ⬇️
master/buildbot/data/builders.py 96.87% <0%> (-0.14%) ⬇️
master/buildbot/data/builds.py 99.3% <0%> (+0.32%) ⬆️
master/buildbot/db/builders.py 100% <0%> (+1.28%) ⬆️
master/buildbot/data/steps.py 99.01% <0%> (+2.81%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08cf306...3776a03. Read the comment docs.

@tardyp tardyp merged commit 7a2cda7 into buildbot:master Jul 22, 2017

32 checks passed

QuantifiedCode No new issues introduced.
Details
bb Build done.
Details
bb/coverage/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/coverage/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/docs/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/flake8/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/flake8/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/isort/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/js/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/pylint/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/smokes/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/smokes/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:14.0.2/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.4.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.5.0/sqla:0.8.0/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.5.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:mysql+mysqldb://travis@127.0.0.1/bbtest Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:sqlite:////tmp/test_db.sqlite Build done.
Details
bb/trial/3.4/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/3.6/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.6/tw:14.0.2/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.6/tw:15.4.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:10.2.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:11.1.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:12.2.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:13.2.0/sqla:latest/db:sqlite:// Build done.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 88.28%)
Details
codecov/project 88.35% (+0.07%) compared to 08cf306
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment