New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporters.gitlab: Use correct codes #3641

Merged
merged 2 commits into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@cmouse
Contributor

cmouse commented Sep 21, 2017

error is not specified as valid status, use failed and cancelled instead.

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragment directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation
reporters.gitlab: Use correct codes
`error` is not specified as valid status, use failed and cancelled instead.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 21, 2017

@cmouse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tardyp, @rodrigc and @rutsky to be potential reviewers.

mention-bot commented Sep 21, 2017

@cmouse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tardyp, @rodrigc and @rutsky to be potential reviewers.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 21, 2017

Codecov Report

Merging #3641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3641   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files         323      323           
  Lines       33896    33896           
=======================================
  Hits        29929    29929           
  Misses       3967     3967
Impacted Files Coverage Δ
master/buildbot/reporters/gitlab.py 97.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0d355...beeeef4. Read the comment docs.

codecov bot commented Sep 21, 2017

Codecov Report

Merging #3641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3641   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files         323      323           
  Lines       33896    33896           
=======================================
  Hits        29929    29929           
  Misses       3967     3967
Impacted Files Coverage Δ
master/buildbot/reporters/gitlab.py 97.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0d355...beeeef4. Read the comment docs.

@tardyp tardyp merged commit c368399 into buildbot:master Sep 21, 2017

31 checks passed

bb Build done.
Details
bb/coverage/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/coverage/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/docs/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/flake8/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/flake8/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/isort/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/js/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/pylint/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/smokes/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/smokes/3.5/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:14.0.2/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.4.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.5.0/sqla:0.8.0/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:15.5.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:mysql+mysqldb://travis@127.0.0.1/bbtest Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/2.7/tw:latest/sqla:latest/db:sqlite:////tmp/test_db.sqlite Build done.
Details
bb/trial/3.4/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial/3.6/tw:latest/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.6/tw:14.0.2/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.6/tw:15.4.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:10.2.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:11.1.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:12.2.0/sqla:latest/db:sqlite:// Build done.
Details
bb/trial_worker/2.7/tw:13.2.0/sqla:latest/db:sqlite:// Build done.
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1b0d355...beeeef4
Details
codecov/project 88.29% remains the same compared to 1b0d355
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tardyp

This comment has been minimized.

Show comment
Hide comment
@tardyp

tardyp Sep 21, 2017

Member

cool thanks!

Member

tardyp commented Sep 21, 2017

cool thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment