Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow urlText in DirectoryUpload #3990

Merged

Conversation

dlmiddlecote
Copy link
Contributor

@dlmiddlecote dlmiddlecote commented Mar 11, 2018

Allow urlText to be set on a DirectoryUpload.

Adresses #3983

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragment directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@codecov
Copy link

codecov bot commented Mar 11, 2018

Codecov Report

Merging #3990 into master will increase coverage by 0.03%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3990      +/-   ##
==========================================
+ Coverage   88.55%   88.59%   +0.03%     
==========================================
  Files         326      326              
  Lines       34321    34485     +164     
==========================================
+ Hits        30392    30551     +159     
- Misses       3929     3934       +5
Impacted Files Coverage Δ
master/buildbot/steps/transfer.py 93.9% <20%> (-0.05%) ⬇️
master/buildbot/steps/worker.py 97.89% <0%> (-0.19%) ⬇️
master/buildbot/master.py 86.19% <0%> (-0.05%) ⬇️
master/buildbot/reporters/mail.py 95.78% <0%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62ef53c...8e921c2. Read the comment docs.

@dlmiddlecote
Copy link
Contributor Author

dlmiddlecote commented Apr 8, 2018

Nudge @tardyp

@tardyp tardyp merged commit 2343836 into buildbot:master Apr 8, 2018
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants