[DO NOT MERGE] test for twisted trunk

[rodrigc]

Follow on to #5591

[codecov]

Codecov Report

Merging #5739 (0be5fc8) into master (500d6d6) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5739      +/-   ##
==========================================
- Coverage   91.72%   91.69%   -0.03%     
==========================================
  Files         340      340              
  Lines       36866    36866              
==========================================
- Hits        33814    33804      -10     
- Misses       3052     3062      +10     

Impacted Files	Coverage Δ
master/buildbot/scripts/cleanupdb.py	86.79% <0.00%> (-13.21%)	⬇️
master/buildbot/__init__.py	90.76% <0.00%> (-1.54%)	⬇️
worker/buildbot_worker/__init__.py	91.04% <0.00%> (-1.50%)	⬇️
master/buildbot/db/connector.py	98.83% <0.00%> (-1.17%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 500d6d6...0be5fc8. Read the comment docs.

[rodrigc]

Trunk fails here:

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/buildbot/buildbot-job/build/sandbox/lib/python3.8/site-packages/twisted/internet/defer.py", line 1445, in _inlineCallbacks
    result = current_context.run(g.send, result)
  File "/buildbot/buildbot-job/build/master/buildbot/test/unit/scripts/test_start.py", line 117, in test_start_timeout_number_string
    res = yield self.runStart(start_timeout='10')
  File "/buildbot/buildbot-job/build/master/buildbot/test/unit/scripts/test_start.py", line 87, in runStart
    return getProcessOutputAndValue(sys.executable, args=args, env=env)
  File "/buildbot/buildbot-job/build/sandbox/lib/python3.8/site-packages/twisted/internet/utils.py", line 174, in getProcessOutputAndValue
    return _callProtocolWithDeferred(
  File "/buildbot/buildbot-job/build/sandbox/lib/python3.8/site-packages/twisted/internet/utils.py", line 28, in _callProtocolWithDeferred
    reactor.spawnProcess(p, executable, (executable,) + tuple(args), env, path)
  File "/buildbot/buildbot-job/build/sandbox/lib/python3.8/site-packages/twisted/internet/posixbase.py", line 386, in spawnProcess
    args, env = self._checkProcessArgs(args, env)
  File "/buildbot/buildbot-job/build/sandbox/lib/python3.8/site-packages/twisted/internet/base.py", line 1088, in _checkProcessArgs
    _arg = argChecker(arg)
  File "/buildbot/buildbot-job/build/sandbox/lib/python3.8/site-packages/twisted/internet/base.py", line 1074, in argChecker
    arg = arg.encode(defaultEncoding)
builtins.TypeError: encode() argument 'encoding' must be str, not None
buildbot.test.unit.scripts.test_start.TestStart.test_start_timeout_number_string
-------------------------------------------------------------------------------

[rodrigc]

Testing this branch in Twisted https://github.com/twisted/twisted/tree/10069-rodrigc-encoding,
I could get all the buildbot tests to pass: https://buildbot.buildbot.net/#/builders/87/builds/3

[p12tic]

twisted/twisted#1502 is now merged, I think we can close this PR too.