Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env override when calling makeRemoteShellCommand #6820

Merged
merged 2 commits into from Mar 30, 2023
Merged

Fix env override when calling makeRemoteShellCommand #6820

merged 2 commits into from Mar 30, 2023

Conversation

jsonar-cpapke
Copy link
Contributor

Before this change, setting env when directly calling makeRemoteShellCommand was effectively ignored. This change updates that to use the override if it exists.

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the newsfragments directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@p12tic
Copy link
Member

p12tic commented Mar 30, 2023

Looks great, thank you!

@p12tic p12tic merged commit f8257b2 into buildbot:master Mar 30, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p12tic p12tic p12tic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsonar-cpapke @p12tic