From 6d8825c27cc6b29e1193283f45b516f9578679d5 Mon Sep 17 00:00:00 2001 From: Zoey Greer Date: Tue, 9 Apr 2024 11:06:59 -0400 Subject: [PATCH] Also delete misses from the cache stats when cleaning up --- server/remote_cache/hit_tracker/hit_tracker.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/remote_cache/hit_tracker/hit_tracker.go b/server/remote_cache/hit_tracker/hit_tracker.go index 56883f91f09..65540db2f9c 100644 --- a/server/remote_cache/hit_tracker/hit_tracker.go +++ b/server/remote_cache/hit_tracker/hit_tracker.go @@ -715,4 +715,8 @@ func CleanupCacheStats(ctx context.Context, env environment.Env, iid string) { if err := c.Delete(ctx, counterKey(iid)); err != nil { log.Warningf("Failed to clean up cache stats for invocation %s: %s", iid, err) } + + if err := c.Delete(ctx, targetMissesKey(iid)); err != nil { + log.Warningf("Failed to clean up cache stats for invocation %s: %s", iid, err) + } }