Slide List not scoped correctly #17

Closed
evanblack opened this Issue Jun 27, 2011 · 3 comments

Comments

Projects
None yet
3 participants
@evanblack

Because the variable vars.slide_list is never defined, the scope doesn't exist and the plugin grabs every li element on the page.

Slide list should be declared under the variables:

$.supersized.vars = {

    // Elements
    slide_list          :   '#slide-list'

};
@jeanmichel71

This comment has been minimized.

Show comment
Hide comment
@jeanmichel71

jeanmichel71 Jul 5, 2011

Same issue here with v3.2.1, I had to set slide_links option to false.
Line 246: $('li', vars.slide_list).click(function(){ ... }
kills all my [li][a href] links

Same issue here with v3.2.1, I had to set slide_links option to false.
Line 246: $('li', vars.slide_list).click(function(){ ... }
kills all my [li][a href] links

@jeanmichel71

This comment has been minimized.

Show comment
Hide comment
@jeanmichel71

jeanmichel71 Jul 5, 2011

in jQuery documentation [http://docs.jquery.com/%24], context should be a DOM element or jQuery object, not a CSS selector

in jQuery documentation [http://docs.jquery.com/%24], context should be a DOM element or jQuery object, not a CSS selector

@samdunn

This comment has been minimized.

Show comment
Hide comment
@samdunn

samdunn Jul 8, 2011

Member

Thanks for pointing this out guys - this should be resolved in 3.2.3 which i just pushed through

Member

samdunn commented Jul 8, 2011

Thanks for pointing this out guys - this should be resolved in 3.2.3 which i just pushed through

@samdunn samdunn closed this Jul 8, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment