Update flickr/js/supersized.flickr.1.1.2.js #66

Merged
merged 1 commit into from Apr 2, 2012

Projects

None yet

3 participants

@JamesChevalier

Changed line 170 from 'item.owner' to 'data.photoset.owner' because that's where the Owner ID is in Flickr's JSON response.
If this line isn't changed, then supersized creates URLs images with 'undefined' as the USER ID.

@JamesChevalier JamesChevalier Update flickr/js/supersized.flickr.1.1.2.js
Changed line 170 from 'item.owner' to 'data.photoset.owner' because that's where the Owner ID is in Flickr's JSON response.
If this line isn't changed, then supersized creates URLs images with 'undefined' as the USER ID.
67d2c25
@samdunn samdunn merged commit b81e0e4 into buildinternet:master Apr 2, 2012
@matt-richardson

As far as I can tell, this only works when you are working based on a photoset.
When you are pulling based on a user, I think it needs to be item.owner.
(caveat - I've spent about 5 minutes looking at this, so please take it with a grain of salt!)

@matt-richardson matt-richardson added a commit to matt-richardson/supersized that referenced this pull request Jun 17, 2012
@matt-richardson matt-richardson Bug fix for data.photoset.owner null
A previous change (pull request #66) appears to have introduced a bug
for user based photos, while fixing a bug for set based photos. This now
uses data.photoset.owner when data.photoset exists, otherwise, reverts
to item.owner.
a3f3524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment