Update flickr/js/supersized.flickr.1.1.2.js #66

Merged
merged 1 commit into from Apr 2, 2012

Conversation

Projects
None yet
3 participants
@JamesChevalier
Contributor

JamesChevalier commented Mar 28, 2012

Changed line 170 from 'item.owner' to 'data.photoset.owner' because that's where the Owner ID is in Flickr's JSON response.
If this line isn't changed, then supersized creates URLs images with 'undefined' as the USER ID.

Update flickr/js/supersized.flickr.1.1.2.js
Changed line 170 from 'item.owner' to 'data.photoset.owner' because that's where the Owner ID is in Flickr's JSON response.
If this line isn't changed, then supersized creates URLs images with 'undefined' as the USER ID.

samdunn added a commit that referenced this pull request Apr 2, 2012

Merge pull request #66 from JamesChevalier/patch-1
Update flickr/js/supersized.flickr.1.1.2.js

@samdunn samdunn merged commit b81e0e4 into buildinternet:master Apr 2, 2012

@matt-richardson

This comment has been minimized.

Show comment
Hide comment
@matt-richardson

matt-richardson Jun 17, 2012

Contributor

As far as I can tell, this only works when you are working based on a photoset.
When you are pulling based on a user, I think it needs to be item.owner.
(caveat - I've spent about 5 minutes looking at this, so please take it with a grain of salt!)

Contributor

matt-richardson commented Jun 17, 2012

As far as I can tell, this only works when you are working based on a photoset.
When you are pulling based on a user, I think it needs to be item.owner.
(caveat - I've spent about 5 minutes looking at this, so please take it with a grain of salt!)

matt-richardson added a commit to matt-richardson/supersized that referenced this pull request Jun 17, 2012

Bug fix for data.photoset.owner null
A previous change (pull request #66) appears to have introduced a bug
for user based photos, while fixing a bug for set based photos. This now
uses data.photoset.owner when data.photoset exists, otherwise, reverts
to item.owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment