Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Update flickr/js/supersized.flickr.1.1.2.js #66

Merged
merged 1 commit into from

3 participants

James Chevalier Matt Richardson Sam Dunn
James Chevalier

Changed line 170 from 'item.owner' to 'data.photoset.owner' because that's where the Owner ID is in Flickr's JSON response.
If this line isn't changed, then supersized creates URLs images with 'undefined' as the USER ID.

James Chevalier JamesChevalier Update flickr/js/supersized.flickr.1.1.2.js
Changed line 170 from 'item.owner' to 'data.photoset.owner' because that's where the Owner ID is in Flickr's JSON response.
If this line isn't changed, then supersized creates URLs images with 'undefined' as the USER ID.
67d2c25
Sam Dunn samdunn merged commit b81e0e4 into from
Matt Richardson

As far as I can tell, this only works when you are working based on a photoset.
When you are pulling based on a user, I think it needs to be item.owner.
(caveat - I've spent about 5 minutes looking at this, so please take it with a grain of salt!)

Matt Richardson matt-richardson referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Matt Richardson matt-richardson referenced this pull request from a commit in matt-richardson/supersized
Matt Richardson matt-richardson Bug fix for data.photoset.owner null
A previous change (pull request #66) appears to have introduced a bug
for user based photos, while fixing a bug for set based photos. This now
uses data.photoset.owner when data.photoset exists, otherwise, reverts
to item.owner.
a3f3524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 28, 2012
  1. James Chevalier

    Update flickr/js/supersized.flickr.1.1.2.js

    JamesChevalier authored
    Changed line 170 from 'item.owner' to 'data.photoset.owner' because that's where the Owner ID is in Flickr's JSON response.
    If this line isn't changed, then supersized creates URLs images with 'undefined' as the USER ID.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  flickr/js/supersized.flickr.1.1.2.js
2  flickr/js/supersized.flickr.1.1.2.js
View
@@ -167,7 +167,7 @@
//create image urls
var photoURL = 'http://farm' + item.farm + '.static.flickr.com/' + item.server + '/' + item.id + '_' + item.secret + '_' + options.image_size + '.jpg';
var thumbURL = 'http://farm' + item.farm + '.static.flickr.com/' + item.server + '/' + item.id + '_' + item.secret + '_t.jpg';
- var photoLink = "http://www.flickr.com/photos/" + item.owner + "/" + item.id + "/";
+ var photoLink = "http://www.flickr.com/photos/" + data.photoset.owner + "/" + item.id + "/";
if (i == 0){
options.slides.splice(0,1,{ image : photoURL, thumb : thumbURL, title : item.title , url : photoLink });
Something went wrong with that request. Please try again.