Add zstd_wrapper#100
Closed
ZacSweers wants to merge 7 commits into
Closed
Conversation
toote
requested changes
Feb 12, 2025
toote
left a comment
toote
left a comment
Contributor
There was a problem hiding this comment.
Changes suggested made me realize I had forgotten to add the wrappers folder to the shellcheck of the pipeline. Thanks!
Co-authored-by: Matías Bellone <toote@users.noreply.github.com>
Co-authored-by: Matías Bellone <toote@users.noreply.github.com>
Co-authored-by: Matías Bellone <toote@users.noreply.github.com>
toote
requested changes
Feb 14, 2025
toote
left a comment
toote
left a comment
Contributor
There was a problem hiding this comment.
Just a very minor issue leftover from another change I requested. After you have made that change I would approve it even without tests as it would be too much to ask. As long as you have tested it successfully I'd be OK with this :)
| fi | ||
|
|
||
| if [ "${OPERATION}" = "compress" ]; then | ||
| check_zstd |
Contributor
There was a problem hiding this comment.
you forgot to remove this reference
| fi | ||
| tar "${TAR_OPTS[@]}" "${SOURCE}" | zstd -o "${TARGET}" | ||
| elif [ "${OPERATION}" = "decompress" ]; then | ||
| check_zstd |
Contributor
Author
|
Fixed! Missed those as I was just accepting suggestions in github heh. Can reconfirm this all worked fine with local testing 
|
pzeballos
deleted the branch
buildkite-plugins:toote_compression_refactoring
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note this adds checks for the binary since I'm not sure if it's safe to assume it's present. Tested these locally with both files and dirs