New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reference to cleanup config flag #199

Closed
nhooyr opened this Issue Feb 11, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@nhooyr
Copy link

nhooyr commented Feb 11, 2019

See

if [[ -n "$(plugin_read_list RUN)" ]] && [[ "$(plugin_read_config CLEANUP "true")" == "true" ]] ; then

plugin_read_config CLEANUP "true"

There is no cleanup flag and therefore that comparison is always true.

@toolmantim

This comment has been minimized.

Copy link
Member

toolmantim commented Feb 11, 2019

This is somewhat of a hack used in the unit tests only, because it’s a tricky one to test for. If you manage to figure out a cleaner approach, would be more than welcome to accept a change.

@toolmantim toolmantim closed this Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment