Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: Add optional dependent services to start #203
I wanted to get this PR out early and get notes before I moved too far along with it.
The gist of it is, links in docker-compose are deprecated and there really isn't a clean way (that I've found) to start dependent services inside of compose unless you do it manually. That's what this PR adds, a deps array to specify dependent services in your yaml that will be started at a scale of 1 for you to test against.
I'm happy to take any feedback or questions you might have around motive or what the end result looks like.
Signed-off-by: Elliott Davis firstname.lastname@example.org
Afaik the depends_on syntax was removed in compose version 3. Links is still there but is marked for deprecation. I am currently leveraging external_links but those don't start dependent containers in compose.…
On Fri, Mar 1, 2019, 6:24 PM Tim Lucas ***@***.***> wrote: Thank you for taking the time to submit a Pull request though! That’s awesome 🙌🏼
I don't believe so, that's basically the point of docker-compose! Check out https://docs.docker.com/compose/compose-file/#depends_on-1.
They deprecated links a while back.
I'd be in favour of a