Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add optional dependent services to start #203

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@elliott-davis
Copy link

elliott-davis commented Mar 1, 2019

I wanted to get this PR out early and get notes before I moved too far along with it.

The gist of it is, links in docker-compose are deprecated and there really isn't a clean way (that I've found) to start dependent services inside of compose unless you do it manually. That's what this PR adds, a deps array to specify dependent services in your yaml that will be started at a scale of 1 for you to test against.

I'm happy to take any feedback or questions you might have around motive or what the end result looks like.

Signed-off-by: Elliott Davis elliott@excellent.io

Elliott Davis
Add optional dependent services to start
Signed-off-by: Elliott Davis <elliott@excellent.io>
@toolmantim

This comment has been minimized.

Copy link
Member

toolmantim commented Mar 2, 2019

Have you investigated the Docker Compose depends_on configuration property? I think that does what you might need, and we may not need an extra plugin configuration option.

@toolmantim

This comment has been minimized.

Copy link
Member

toolmantim commented Mar 2, 2019

Thank you for taking the time to submit a pull request though! That’s awesome 🙌🏼😊

@elliott-davis

This comment has been minimized.

Copy link
Author

elliott-davis commented Mar 2, 2019

@lox

This comment has been minimized.

Copy link
Collaborator

lox commented Mar 2, 2019

Afaik the depends_on syntax was removed in compose version 3

I don't believe so, that's basically the point of docker-compose! Check out https://docs.docker.com/compose/compose-file/#depends_on-1.

They deprecated links a while back.

I'd be in favour of a depends_on param that allows extra dependencies to be added though!

@elliott-davis

This comment has been minimized.

Copy link
Author

elliott-davis commented Mar 3, 2019

Version 3 no longer supports the condition form of depends_on

I misread that line in the docs

I'll get this PR fixed up based on your suggestion. Thanks again for the feedback!

@toolmantim

This comment has been minimized.

Copy link
Member

toolmantim commented Mar 3, 2019

Alternatively, if you don't need the option anymore, it's probably best if we just leave it until someone needs the extra functionality?

@elliott-davis

This comment has been minimized.

Copy link
Author

elliott-davis commented Mar 4, 2019

depends on worked as advertised - closing this - thanks again @toolmantim

@toolmantim

This comment has been minimized.

Copy link
Member

toolmantim commented Mar 4, 2019

🙌🏼 Nice one @elliott-davis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.