Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement text and select block steps #25

Merged
merged 1 commit into from Feb 13, 2019
Merged

Implement text and select block steps #25

merged 1 commit into from Feb 13, 2019

Conversation

lox
Copy link

@lox lox commented Feb 6, 2019

This provides an implementation of https://buildkite.com/docs/pipelines/block-step, using the UI components from https://github.com/manifoldco/promptui.

render1549425024351

@lox lox requested a review from toolmantim February 6, 2019 03:54
@lox
Copy link
Author

lox commented Feb 6, 2019

@toolmantim the code is a mess, but I'd love feedback on the interaction design and things like spacing, etc.

@toolmantim
Copy link

This is awesome! There’s not a lot to say, it looks pretty good.

Perhaps the only two things I can see are the ✔️ character seems odd for a block, and that you could probably do without the final [y/n] — perhaps just unblock as soon as they fill out the last field? (Unless it’s a field-less block step, in which case you’ll probably still need it)

@toolmantim toolmantim removed their request for review February 12, 2019 01:26
@lox
Copy link
Author

lox commented Feb 13, 2019

I'm going to merge this for now!

@lox lox merged commit 8641d80 into master Feb 13, 2019
@lox lox deleted the implement-block-steps branch February 13, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants