New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in docker compose plugin example #395

Closed
nhooyr opened this Issue Feb 6, 2019 · 4 comments

Comments

3 participants
@nhooyr
Copy link

nhooyr commented Feb 6, 2019

https://buildkite.com/docs/pipelines/plugins#using-a-plugin

steps:
  # Prebuild the app image, upload it to a registry for later steps
  - label: ":docker: Build"
    plugins:
      - docker-compose#v1.0.0:
          build: app
          image-repository: index.docker.io/org/repo

  - wait

  # Use the app image built above to run concurrent tests
  - label: ":docker: Test %n"
    command: test.sh
    parallelism: 25
    plugins:
      - docker-compose#v1.0.0:
          run: app

I believe that last run step needs a image-repository field as well.

@nhooyr nhooyr changed the title bug in Buildkite Agent plugins example bug in docker compose plugin example Feb 6, 2019

@lox

This comment has been minimized.

Copy link
Contributor

lox commented Feb 6, 2019

It shouldn't, that information is passed via meta-data.

@nhooyr

This comment has been minimized.

Copy link
Author

nhooyr commented Feb 6, 2019

Ah neat.

@nhooyr nhooyr closed this Feb 6, 2019

@nhooyr nhooyr reopened this Feb 9, 2019

@nhooyr

This comment has been minimized.

Copy link
Author

nhooyr commented Feb 9, 2019

Probably deserves at least a comment in the example.

@toolmantim

This comment has been minimized.

Copy link
Member

toolmantim commented Feb 13, 2019

I tried adding it, but I think it just pollutes the clarity of the example, which is meant to just show the syntax for using a plugin twice in a pipeline. Thanks for the feedback though, it was a good suggestion!

@toolmantim toolmantim closed this Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment