Replace lifecycled without SNS/SQS #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
sj26
force-pushed
the
lifecycled-the-second
branch
from
9fd4a10
to
23ae9f0
Compare
| @@ -442,22 +466,28 @@ Resources: | |||
| 06-run-bootstrap-script: | |||
| test: test -n "$(BootstrapScriptUrl)" | |||
| command: | | |||
| #!/bin/bash -euo pipefail | |||
There was a problem hiding this comment.
(This option caused an error for me)
sj26
force-pushed
the
lifecycled-the-second
branch
from
23ae9f0
to
19cfbc1
Compare
|
Fixes #130 |
|
Stack JSON URL: |
toolmantim
force-pushed
the
lifecycled-the-second
branch
from
5cdf282
to
6a7e3f8
Compare
|
:( |
|
Sorry @lox! Turns out you can do a Which means you can just poll your own state to see the state change. |
| @@ -428,7 +428,7 @@ Resources: | |||
| --query AutoScalingInstances[].LifecycleState --output text)" | |||
| logger -t lifecycled "Lifecycle state for \$INSTANCE_ID: \$LIFECYCLE_STATE" | |||
| if [[ "\$LIFECYCLE_STATE" == "Terminating:Wait" ]]; then | |||
| logger -t lifecycled "Time to shut it all down!" | |||
There was a problem hiding this comment.
Oh sorry, this would have broken. Woops!
There was a problem hiding this comment.
Oh no, it did work in the example. Perhaps it's too enthusiastic, though.
|
Rolling updates work AOK, scaling up and down works AOK. I think this is good to 🚀 |
toolmantim
force-pushed
the
lifecycled-the-second
branch
from
f0454e1
to
285bdc0
Compare
|
This seems to be working well 👍 |
chloeruka
added a commit
that referenced
this pull request
Apr 27, 2021
These appear to be vestigial since we no longer use SNS/SQS queue for agent lifecycle operations when we removed that for LifecycleD in #135.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had some trouble with SQS lifecycle handling, so we can try something a little less sophisticated and POLL FOR GREAT JUSTICE. Maybe. Haha.
It definitely works: