New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job kill timeout should be configurable #464

Closed
DazWorrall opened this Issue Oct 1, 2018 · 2 comments

Comments

2 participants
@DazWorrall

DazWorrall commented Oct 1, 2018

It's currently hardcoded to 10 seconds:

https://github.com/buildkite/agent/blob/c9645249f076beef3cebce34dc9980fe8c54d502/process/process.go#L314-L319

We have some cases where it's really not unusual for a graceful shutdown to take longer than that, so it would be useful to be able to configure this - per job would be ideal, but as an agent option would be a step forward.

cc @lox

@lox

This comment has been minimized.

Show comment
Hide comment
@lox

lox Oct 1, 2018

There is an issue over at buildkite/agent#700 with some context @DazWorrall

lox commented Oct 1, 2018

There is an issue over at buildkite/agent#700 with some context @DazWorrall

@DazWorrall

This comment has been minimized.

Show comment
Hide comment
@DazWorrall

DazWorrall Oct 2, 2018

Perfect, I'll subscribe to that 👍

DazWorrall commented Oct 2, 2018

Perfect, I'll subscribe to that 👍

@DazWorrall DazWorrall closed this Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment